Create detection LLM endpoint #232

iam-flo · 2025-01-24T16:09:09Z

Motivation

Fixes #123. Enables detection of bad PR description practices based on predefined rules in the application server.

Description

Sends PR description and rules to LLM for evaluation.
Configures LLM to analyze descriptions and detect bad practices.

FelixTJDietrich

Here are some review comments. Since the migration is now split over two PRs maybe it makes sense to just merge the stacked PRs together after you have implemented the review comments and then we just merge jointly for the production deployment.

FelixTJDietrich · 2025-02-19T17:31:39Z

server/application-server/src/main/java/de/tum/in/www1/hephaestus/activity/ActivityService.java

@@ -46,7 +48,7 @@ public ActivityDTO getActivity(String login) {
            pullRequestBadPracticeRepository.findAssignedByLoginAndOpen(login);

        Map<PullRequest, List<PullRequestBadPracticeDTO>> pullRequestBadPracticesMap = openPulLRequestBadPractices
-            .stream()
+            .stream().filter(pullRequestBadPractice -> !pullRequestBadPractice.isResolved())


This means that we are only showing the unresolved detected bad practices? So the resolved ones disappear from the UI?

Yes, but in the follow up Pr I adjusted the detected logic and there also show resolved bad practices

...on-server/src/main/java/de/tum/in/www1/hephaestus/activity/model/PullRequestBadPractice.java

...a/de/tum/in/www1/hephaestus/activity/badpracticedetector/PullRequestBadPracticeDetector.java

...ication-server/src/main/java/de/tum/in/www1/hephaestus/config/BadPracticeDetectorConfig.java

FelixTJDietrich · 2025-02-19T17:44:18Z

server/application-server/src/main/resources/db/changelog/1738063112622_changelog.xml

@@ -1,8 +1,8 @@
 <?xml version="1.1" encoding="UTF-8" standalone="no"?>
 <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:ext="http://www.liquibase.org/xml/ns/dbchangelog-ext" xmlns:pro="http://www.liquibase.org/xml/ns/pro" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog-ext http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd http://www.liquibase.org/xml/ns/pro http://www.liquibase.org/xml/ns/pro/liquibase-pro-latest.xsd http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
    <changeSet author="iam-flo" id="1738063112622-1">
-        <createTable tableName="pull_request_bad_practice">
-            <column name="id" type="BIGINT">
+        <createTable tableName="pullrequestbadpractice">


Are you sure about this migration? I think if this builds on the previous migration it will not work as intended. You are never deleting the pull_request_bad_practice table and migrating its data. Maybe you also don't need to rename it in the first place.

Also is the @NonNull that you added considered?

i agree, we should merge this first and then i will rework this migration

server/intelligence-service/app/detector/bad_practice_detector.py

FelixTJDietrich · 2025-02-19T17:49:11Z

...pp/src/app/user/pull-request-bad-practice-card/pull-request-bad-practice-card.component.html

@@ -58,7 +58,7 @@
        <brn-collapsible-content>
          @for (badpractice of badPractices(); track badpractice.title) {
            <brn-separator hlmSeparator />
-            <app-bad-practice-card [title]="badpractice.title" [description]="badpractice.description" [resolved]="false"></app-bad-practice-card>
+            <app-bad-practice-card [title]="badpractice.title" [description]="badpractice.description" [resolved]="badpractice.resolved"></app-bad-practice-card>


Here you can potentially also just pass the DTO type as input so you don't need to do each field separately

it is done similarly in the other components. what is the best practice?

coderabbitai · 2025-02-20T15:50:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

iam-flo self-assigned this Jan 24, 2025

github-actions bot added intelligence-service size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 24, 2025

iam-flo added the autocommit-openapi label Jan 24, 2025

iam-flo force-pushed the 226-create-llm-based-detection-for-pr-descriptions branch from ebe5fe7 to a91ac59 Compare January 27, 2025 11:08

github-actions bot added client application-server webhook-ingest size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. autocommit-openapi labels Jan 27, 2025

iam-flo force-pushed the 223-creating-activity-dashboard branch from 79c3666 to 848f07e Compare January 27, 2025 11:10

iam-flo force-pushed the 226-create-llm-based-detection-for-pr-descriptions branch from 51434ac to a4073a0 Compare January 27, 2025 11:15

iam-flo force-pushed the 223-creating-activity-dashboard branch from 92b2879 to 372ac51 Compare January 28, 2025 10:21

iam-flo force-pushed the 226-create-llm-based-detection-for-pr-descriptions branch 2 times, most recently from da0708f to a6678bc Compare January 28, 2025 12:26

iam-flo added the autocommit-openapi label Jan 28, 2025

github-actions bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed autocommit-openapi size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 28, 2025

iam-flo added the autocommit-openapi label Jan 28, 2025

github-actions bot removed the autocommit-openapi label Jan 28, 2025

iam-flo requested a review from FelixTJDietrich January 31, 2025 17:01

iam-flo force-pushed the 223-creating-activity-dashboard branch from 72b78fa to 98d9c8e Compare February 4, 2025 13:02

iam-flo force-pushed the 226-create-llm-based-detection-for-pr-descriptions branch from fb9e0b5 to 5b25cbf Compare February 4, 2025 13:03

iam-flo mentioned this pull request Feb 9, 2025

Follow up PR with new detect bad practices for individual PR, better LLM prompt, responsive spinners, and ready to merge trigger for detection #245

Open

FelixTJDietrich changed the title ~~create detection llm endpoint~~ Create detection LLM endpoint Feb 19, 2025

FelixTJDietrich requested changes Feb 19, 2025

View reviewed changes

iam-flo added a commit that referenced this pull request Feb 20, 2025

rework after review #232

144efa3

iam-flo and others added 11 commits February 20, 2025 16:50

create detection llm endpoint

15c02bc

create detection models #226

8138c8b

chore: update API specs and client

ca3bfeb

create rule based detection of bad practices(#226)

54200c4

rework llm based detection #226

8ad1f93

chore: update API specs and client

0851514

connect to llm #226

f478913

chore: update API specs and client

5c099b7

connect bad practice detection(#223)

8690f2c

adjust changelog(#223)

9660567

rework after review #232

0951d43

iam-flo force-pushed the 226-create-llm-based-detection-for-pr-descriptions branch from 144efa3 to 0951d43 Compare February 20, 2025 15:51

iam-flo added 2 commits February 20, 2025 16:55

reformatting #226

c2a20a9

webapp reformatting #226

e06460d

iam-flo requested a review from FelixTJDietrich February 20, 2025 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create detection LLM endpoint #232

Create detection LLM endpoint #232

iam-flo commented Jan 24, 2025 •

edited

Loading

FelixTJDietrich left a comment

FelixTJDietrich Feb 19, 2025

iam-flo Feb 20, 2025

FelixTJDietrich Feb 19, 2025

iam-flo Feb 20, 2025

FelixTJDietrich Feb 19, 2025

iam-flo Feb 20, 2025

coderabbitai bot commented Feb 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Create detection LLM endpoint #232

Are you sure you want to change the base?

Create detection LLM endpoint #232

Conversation

iam-flo commented Jan 24, 2025 • edited Loading

Motivation

Description

FelixTJDietrich left a comment

Choose a reason for hiding this comment

FelixTJDietrich Feb 19, 2025

Choose a reason for hiding this comment

iam-flo Feb 20, 2025

Choose a reason for hiding this comment

FelixTJDietrich Feb 19, 2025

Choose a reason for hiding this comment

iam-flo Feb 20, 2025

Choose a reason for hiding this comment

FelixTJDietrich Feb 19, 2025

Choose a reason for hiding this comment

iam-flo Feb 20, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Feb 20, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

iam-flo commented Jan 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)